API: Add tests for DateTimeUtil.microsToMillis#16773
Open
vishnuprakaz wants to merge 3 commits into
Open
Conversation
Author
|
The failing test |
nssalian
approved these changes
Jun 12, 2026
ebyhr
reviewed
Jun 12, 2026
| } | ||
|
|
||
| @Test | ||
| public void microsToMillis() { |
Member
There was a problem hiding this comment.
I would move this test above microsToNanos so we can sort millis → nanos.
Author
|
Thanks for the review! Good idea @ebyhr moved it above nanosToMicros. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a unit test for
DateTimeUtil.microsToMillis, which has had no directtest since it was added in #2512.
The method was copied from Spark's
DateTimeUtilsand is used by Spark'sProcedureInput. It usesMath.floorDiv, so pre-1970 timestamps round downrather than toward zero the test covers a positive and a negative value to
keep that behavior correct